Repository navigation
fix(cli): retire commands whose API operations no longer exist - #133
polylane[bot] wants to merge 1 commit into
Conversation
Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
|
Warning Polylane could not verify the production impact of this pull request. Retired feed, memory, note and service-find commands call API operations the live document no longer publishes, so they could not typecheck. The checkout shows all resolveServiceId callers updated and no broken imports; no workspace cloud resource runs this CLI. Evidence read: Also considered · 3 refuted
Analysed against 9 cloud accounts and 1 repository
Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to. Polylane analysed Rate this review: 👍 helpful · 👎 not helpful · 😕 confusing |
Fixes: CLI typecheck fails: commands call operations the live API does not publish
The CLI's continuous integration fails at typecheck because fifteen commands call platform API operations that the published API document no longer contains: the workspace activity feed, daily notes, memory records, and natural-language service lookup. An agent that follows the shipped skill gets a not-found response from those commands. After this merges the CLI compiles against the API contract it is gated on.
Why this fix
The live API document and the API repository's own guarded document builder both report the same 253 paths, and neither defines the operations these commands call, so every one of them could only fail at runtime. Regenerating the client from that document and typechecking reproduces the twenty-one errors on main, and the same commands pass after removing them. One question stays open: the CLI's readme and agent skill still advertised the retired commands, so if the platform means to keep workspace feed, daily notes or natural-language service lookup, the API has to publish those operations. The investigation holds the exact times and payloads.
Fix walkthrough
Watch the fix explained (3:05). Recorded for commit
3b0464bc9235ea2c8388f0857a6cef01bb957d8b.Causal chain
32 files changed (+50/-762)
ERRORS.md: modified, +1/-1README.md: modified, +0/-1skill/SKILL.md: modified, +5/-8src/commands/feed/index.ts: removed, +0/-4src/commands/feed/list.ts: removed, +0/-145src/commands/feed/summary.ts: removed, +0/-46src/commands/index.ts: modified, +0/-6src/commands/memory/delete.ts: removed, +0/-34src/commands/memory/find.ts: removed, +0/-39src/commands/memory/index.ts: removed, +0/-13src/commands/memory/list.ts: removed, +0/-53src/commands/memory/save.ts: removed, +0/-48src/commands/memory/show.ts: removed, +0/-19src/commands/note/delete.ts: removed, +0/-34src/commands/note/global-clear.ts: removed, +0/-32src/commands/note/global-set.ts: removed, +0/-21src/commands/note/global-show.ts: removed, +0/-17src/commands/note/index.ts: removed, +0/-17src/commands/note/list.ts: removed, +0/-49src/commands/note/save.ts: removed, +0/-44Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment.